Add UTF-8 validation fast paths in Wtf8Buf
#137154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
ChrisDenton
reviewed
Feb 17, 2025
library/std/src/sys_common/wtf8.rs
Outdated
Comment on lines
173
to
176
| if let Some(s) = self.as_known_utf8() { | ||
| return fmt::Display::fmt(s, formatter); | ||
| } | ||
| fmt::Display::fmt(&**self, formatter) |
There was a problem hiding this comment.
This could just be an if/else rather than early return
thaliaarchi
force-pushed
the
wtf8-fast-paths
branch
from
c5b3cb5 to
eb14652
Compare
|
Now that #137155 is finally through the merge queue, I've addressed your feedback and rebased onto it to resolve conflicts. |
|
Ok, looks good! @bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup because it's small |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 14 pull requests Successful merges: - rust-lang#136576 (pass optimization level to llvm-bitcode-linker) - rust-lang#137154 (Add UTF-8 validation fast paths in `Wtf8Buf`) - rust-lang#137311 (Enable `f16` for MIPS) - rust-lang#137320 (fix(rustdoc): Fixed stability version in rustdoc) - rust-lang#137529 (remove few unused args) - rust-lang#137544 (tests: Add regression test for derive token invalidation (rust-lang#81099)) - rust-lang#137559 (run some tests on emscripten again) - rust-lang#137601 (ssa/mono: deduplicate `type_has_metadata`) - rust-lang#137603 (codegen_llvm: avoid `Deref` impls w/ extern type) - rust-lang#137604 (trait_sel: resolve vars in host effects) - rust-lang#137609 (Complete the list of resources used in rustdoc output) - rust-lang#137613 (hir_analysis: skip self type of host effect preds in variances_of) - rust-lang#137614 (fix doc in library/core/src/pin.rs) - rust-lang#137622 (fix attribute-related ICE when parsing macro on the rhs of a name-value attribute) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup merge of rust-lang#137154 - thaliaarchi:wtf8-fast-paths, r=ChrisDenton Add UTF-8 validation fast paths in `Wtf8Buf` This adds two more fast paths for UTF-8 validation in `Wtf8Buf`, making use of the `is_known_utf8` flag added in rust-lang#96869 (Optimize `Wtf8Buf::into_string` for the case where it contains UTF-8). r? `@ChrisDenton`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two more fast paths for UTF-8 validation in
Wtf8Buf, making use of theis_known_utf8flag added in #96869 (OptimizeWtf8Buf::into_stringfor the case where it contains UTF-8).r? @ChrisDenton